Fix eventHeader casing #583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateprewitt
approved these changes
Oct 22, 2025
alexgromero
pushed a commit
to alexgromero/smithy-python
that referenced
this pull request
Oct 24, 2025
SamRemis
added a commit
that referenced
this pull request
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently no services use event headers in smithy python. A typo in the casing of the event streaming header will cause issues when serializing and deserializing events with headers. The fact that we cannot correctly identify the member location as a header means the values will always end up in the event's body.
See smithy's docs for more information on the trait. See smithy's source code for confirmation of the correct casing.